config.ScrapeConfig.Validate: Fix MetricNameEscapingScheme error messages #16801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the error messages in ScrapeConfig.Validate to reference the proper MetricNameEscapingScheme field and ensures the received value is quoted in the output.
- Replace incorrect field references (
MetricNameValidationScheme) withMetricNameEscapingScheme - Add single quotes around the “got” value in both error messages
Comments suppressed due to low confidence (2)
config/config.go:910
- [nitpick] Consider aligning terminology with the field name by replacing "name escaping method" with "metric name escaping scheme" for consistency, e.g.,
unknown global metric name escaping scheme specified.
return fmt.Errorf("unknown global name escaping method specified, must be one of '%s', '%s', '%s', or '%s', got '%s'", model.AllowUTF8, model.EscapeUnderscores, model.EscapeDots, model.EscapeValues, globalConfig.MetricNameEscapingScheme)
config/config.go:924
- [nitpick] Similarly, update the message to reference "metric name escaping scheme" instead of "name escaping method" to keep terminology consistent with the configuration field.
return fmt.Errorf("unknown scrape config name escaping method specified, must be one of '%s', '%s', '%s', or '%s', got '%s'", model.AllowUTF8, model.EscapeUnderscores, model.EscapeDots, model.EscapeValues, c.MetricNameEscapingScheme)
roidelapluie
approved these changes
Jun 30, 2025
bboreham
reviewed
Jun 30, 2025
simonpasquier
approved these changes
Jun 30, 2025
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
MetricNameEscapingSchemeerror messages inconfig.ScrapeConfig.Validate.