Add health & text filtering on the /rules page #16605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses part of #16515 For now, I'm adding very similar filtering to the /rules page as we have on the /alerts page, with the difference being: * The state filter filters by rule health (ok/warn/unknown) instead of alert state (firing/pending/inactive) * We don't collect & show detailed stats on the different state counts as we do on the /alerts page There is a lot of copied / very similar code between those two pages (and also some others) around filtering and pagination, so maybe there is an opportunity for more code sharing in the future here. Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv
commented
May 16, 2025
Nexucis
reviewed
May 19, 2025
Nexucis
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #16515
For now, I'm adding very similar filtering to the /rules page as we have on the /alerts page, with the difference being:
There is a lot of copied / very similar code between those two pages (and also some others) around filtering and pagination, so maybe there is an opportunity for more code sharing in the future here.