Skip to content

promql: don't emit a value from histogram_fraction or histogram_quantile if classic and native histograms are present at the same timestamp #16552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

promql: don't emit a value from histogram_fraction or histogram_quantile if classic and native histograms are present at the same timestamp #16552

merged 1 commit into from
May 8, 2025

Conversation

charleskorn
Copy link
Contributor

This PR fixes #16551, which is a regression introduced in #16095.

@charleskorn
promql: don't emit a value from histogram_fraction or `histogram_qu…
2c0f02a 
…antile` if classic and native histograms are present at the same timestamp

Signed-off-by: Charles Korn <charles.korn@grafana.com>
@charleskorn charleskorn mentioned this pull request May 5, 2025
Merged
1 task
@charleskorn charleskorn marked this pull request as ready for review May 5, 2025 23:59
@charleskorn charleskorn requested a review from roidelapluie as a code owner May 5, 2025 23:59
@krajorama krajorama self-requested a review May 8, 2025 07:13
krajorama
krajorama approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like a straightforward implementation of the classic histogram related delete(enh.signatureToMetricWithBuckets, string(enh.lblBuf)) for native histograms without much overhead.

@krajorama krajorama merged commit f0471ff into prometheus:main May 8, 2025
27 checks passed
@charleskorn charleskorn mentioned this pull request May 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krajorama krajorama krajorama approved these changes

@roidelapluie roidelapluie Awaiting requested review from roidelapluie roidelapluie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

histogram_quantile and histogram_fraction return values when both classic and native histograms are present
2 participants
@charleskorn @krajorama