refactor: use slices.Contains to simplify code #16523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
Apr 30, 2025
machine424
approved these changes
Apr 30, 2025
Thanks for your review. Modified. Please review again. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors several code sections to replace manual loops with the standard library's slices.Contains, simplifying and clarifying membership checks.
- Simplifies the code in postings, tests, labels, Kubernetes discovery, config, and main packages by replacing explicit loops with slices.Contains.
- Improves overall readability without altering behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsdb/index/postings.go | Replaced loop with slices.Contains to check for EmptyPostings(). |
| rules/manager_test.go | Simplified metric name check using slices.Contains. |
| model/labels/regexp.go | Replaced explicit loops with slices.Contains in matchers. |
| model/labels/labels_common.go | Used slices.Contains instead of loop for label filtering. |
| discovery/kubernetes/kubernetes.go | Simplified role selector validation with slices.Contains. |
| config/config.go | Reordered imports and replaced loop with slices.Contains in API version validation. |
| cmd/prometheus/main.go | Refactored duplicate flag value check using slices.Contains. |
aknuds1
approved these changes
May 4, 2025
Modified. Please review again. |
bboreham
reviewed
May 8, 2025
Signed-off-by: hardlydearly <799511800@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.