discovery: add label_selector to hetzner service discovery
#16512
Conversation
2e28fdb to
873cf52
Compare
There was a problem hiding this comment.
Thanks for this.
I assume you cannot use __meta_hetzner_hcloud_label_xxx labels with relabeling to get rid of the unwanted targets.
Even if you just "don't" want to do that, it's still a legit feature as we already allow to do that for other SD.
I assume you did test this manually and I think the tests on hetznercloud/hcloud-go side are enough.
By the way, since you work at Hetzner, we’re looking for a point of contact to help review and validate API related changes. Would you or someone on your team be interested in helping us with that? (looking at the history https://github.com/prometheus/prometheus/commits/main/discovery/hetzner, it should be light workload)
873cf52 to
481d12a
Compare
Allows to filter the servers when sending the listing request to the API. This feature is only available when using the `role=hcloud`. See https://docs.hetzner.cloud/#label-selector for details on how to use the label selector. Signed-off-by: Jonas Lammler <jonas.lammler@hetzner-cloud.de>
481d12a to
08982b1
Compare
This is actually another valid option, but depending on the amount of server in a user's project, this should still reduce the load on both prometheus and our API by processing less data from the start.
Sure, you may contact me @jooola or @apricote for anything related to the hetzner service discovery.
Indeed, I did test this manually. I rebased the changes on top of the main branch. |
|
Awesome! Thanks for the reactivity! |
Allows to filter the servers when sending the listing request to the API. This feature is only available when using the
role=hcloud.See https://docs.hetzner.cloud/#label-selector for details on how to use the label selector.