Add global config option for always_scrape_classic_histograms #16452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krajorama could you help review this PR that addresses #16371? |
5090930 to
f72f39d
Compare
krajorama
approved these changes
Apr 22, 2025
f72f39d to
29a6ae6
Compare
Thank you! Fixed those white space issues |
|
We are missing documentation here. |
krajorama
requested changes
Apr 29, 2025
There was a problem hiding this comment.
@roidelapluie is right, needs documentation.md update, please see #16226 for reference.
29a6ae6 to
caa2efd
Compare
|
Thanks @roidelapluie and @krajorama . I've updated the documentation for this |
Addresses prometheus#16371 This will help with migrating to native histograms with `convert_classic_histograms_to_nhcb` since users may still need to keep the classic histograms during a migration Signed-off-by: chardch <otwordsne@gmail.com>
caa2efd to
a1c157a
Compare
krajorama
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #16371