ci: update golangci-lint to v2.0.2 and adjust configuration #16356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05e21a9 to
0b6f490
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
0b6f490 to
c91d72c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the golangci-lint configuration to v2.0.2, ensuring that both CI workflows and supporting configuration files are in sync with the new version. It also adjusts the configuration settings to include new formatters and enables staticcheck with custom exclusions.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/golangci-lint.yml | Updated the golangci-lint GitHub Action and version to v2.0.2 |
| .golangci.yml | Revised configuration structure, added formatters, and configured staticcheck with custom rules |
| .github/workflows/ci.yml | Updated the golangci-lint GitHub Action and version to v2.0.2 for CI consistency |
Files not reviewed (1)
- Makefile.common: Language not supported
Comments suppressed due to low confidence (2)
.golangci.yml:169
- [nitpick] Consider clarifying or addressing the FIXME note in the staticcheck configuration to ensure that the intended linting behavior is clear before merging. This will help prevent unexpected linting issues in dependent projects.
# FIXME: We should enable this check once we have fixed all the issues.
.golangci.yml:132
- [nitpick] Consider using consistent string quotation (e.g. double quotes) for configuration values across the file for better readability and consistency.
- allowTypesBefore: '*testing.T,testing.TB'
aknuds1
requested changes
Apr 1, 2025
|
I made a PR to fix issues found by golangci-lint v2.0.2 :) |
Yes but it is fixed by golangci/golangci-lint#5654 and will be included in golangci-lint next release |
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
aknuds1
reviewed
Apr 2, 2025
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
This was referenced Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates golangci-lint to v2.0.2 with the associated configuration in workflows and script
Note: With the modification of script, it will require an update for every dependent project.