fix (auto-reload): failing to auto-reload on changes to rule and scrape config files #16340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fed35be to
8a52b04
Compare
|
Thanks; the code seems plausible. Can you explain what is going on in the tests? |
80183d3 to
ecc9d15
Compare
|
Tests have been updated to use a config with relative or absolute pathing and ensure the checksums are changing as expected. Not sure what the idea behind the original changes were. |
roidelapluie
reviewed
Apr 2, 2025
Signed-off-by: Benjamin Godding <ben.godding@bright.ai>
ecc9d15 to
c024fc2
Compare
roidelapluie
approved these changes
Apr 7, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15673
The original PR for this issue has seemingly stalled out and I need this resolved. This PR should address the concerns brought up by @bboreham and utilizes the common config function
JoinDirfollowing what is done in SetDirectory