Migrate otlptranslator package to prometheus/otlptranslator #16240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
c2e653f to
80caee4
Compare
jesusvazquez
approved these changes
Mar 20, 2025
|
Taking a look, thanks. |
aknuds1
requested changes
Mar 20, 2025
There was a problem hiding this comment.
Imports need to be reorganized a bit. I might also open a PR to otlp-prometheus-translator, because I possibly spotted some problems.
storage/remote/otlptranslator/prometheusremotewrite/histograms_test.go
Outdated
Show resolved
Hide resolved
storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go
Outdated
Show resolved
Hide resolved
storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Imports re-organized. Could you share what problems are those? I may have more time than you to work on this, so maybe I could fix those problems |
aknuds1
requested changes
Mar 20, 2025
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative for #16089. This time, the package was moved to its own repository instead of Prometheus/common. We're also not making any modifications whatsoever to the codebase, it's just a clean move.
Additional modifications will be done in separate PRs to make the review process easier.