backport[2.53]: config: set gogc default value when config body is empty (#16052) #16090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
417db53 to
76e94ae
Compare
f0a890e to
f8febd8
Compare
The used version had a no-longer-supported actions/upload-artifact version Which led to: Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ as in https://github.com/prometheus/prometheus/actions/runs/13591433692/job/38242934626 Signed-off-by: machine424 <ayoubmrini424@gmail.com>
avoiding Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: 0c45773b623bea8c8e75f6c82b208c3cf94ea4f9`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down like in https://github.com/prometheus/prometheus/actions/runs/13678387950/job/38244352964?pr=16090 Signed-off-by: machine424 <ayoubmrini424@gmail.com>
…16052) * fix: set gogc default value when config body is empty Signed-off-by: Danial Eskandari <doneskandari@gmail.com> * refactor: explicitly check value 75 in `TestGoGCDefaultValueOnEmptyConfigBody` add GoGC assertion in `TestEmptyConfig`, also removed the no longer needed runtime config assignment in `TestEmptyGlobalBlock` Signed-off-by: Danial Eskandari <doneskandari@gmail.com> * refactor: remove `TestGoGCDefaultValueOnEmptyConfigBody` to reduce duplicate assertions Signed-off-by: Danial Eskandari <doneskandari@gmail.com> --------- Signed-off-by: Danial Eskandari <doneskandari@gmail.com> Signed-off-by: machine424 <ayoubmrini424@gmail.com>
krajorama
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: set gogc default value when config body is empty
refactor: explicitly check value 75 in
TestGoGCDefaultValueOnEmptyConfigBodyadd GoGC assertion in
TestEmptyConfig, also removed the no longer needed runtime config assignment inTestEmptyGlobalBlockTestGoGCDefaultValueOnEmptyConfigBodyto reduce duplicate assertionsbackporting #16052 to LTS 2.53
Had to update
prometheus/promciandactions/cache