-
Notifications
You must be signed in to change notification settings - Fork 9.8k
PoC: Type and unit labels proposal #15683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: David Ashpole <dashpole@google.com>
Signed-off-by: David Ashpole <dashpole@google.com>
/prombench v3.0.1 |
⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️ Compared versions: After the successful deployment (check status here), the benchmarking results can be viewed at: Available Commands:
|
Some learnings so far @dashpole looking on http://prombench.prometheus.io/grafana/d/7gmLoNDmz/prombench?orgId=1&var-pr-number=15683&var-RuleGroup=All&var-prNumber=15683&from=1734426543125&to=1734512943126 Somehow this change either reduces the cardinality of Prometheus OR stops Prometheus from ingesting all data 🤔 I see 3.0 have 2-4x times more metrics and chunks. Our source of metrics as of now (we are switching to avalanche soon): (config, deploy, code). 37 times more allocations for this PR, which suggest something is off. This PR uses less memory overall, likely because of less metrics being stored. This PR uses 5x more CPU We kind of scrape the same amount of samples though: Nothing super interesting in logs other than occasional failed scrape targets. |
Scrapes look healthy: http://34.89.207.251/15683/prometheus-pr/targets?pool= |
/prombench cancel Going to cancel prombench run, so we can unblock other benchmarks runs. |
Benchmark cancel is in progress. |
As agreed in our sync I rebased and only add label in a separate PR #16025 -- I noticed potential alternative when it comes to storage model. |
I'm closing this one since #16228 got merged, please let me know if it should remain open! |
PoC for prometheus/proposals#39