Skip to content

Conversation

dashpole
Copy link
Contributor

@bwplotka
Copy link
Member

/prombench v3.0.1

@prombot
Copy link
Contributor

prombot commented Dec 17, 2024

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-15683 and v3.0.1

After the successful deployment (check status here), the benchmarking results can be viewed at:

Available Commands:

  • To restart benchmark: /prombench restart v3.0.1
  • To stop benchmark: /prombench cancel
  • To print help: /prombench help

@bwplotka
Copy link
Member

Some learnings so far @dashpole looking on http://prombench.prometheus.io/grafana/d/7gmLoNDmz/prombench?orgId=1&var-pr-number=15683&var-RuleGroup=All&var-prNumber=15683&from=1734426543125&to=1734512943126

Somehow this change either reduces the cardinality of Prometheus OR stops Prometheus from ingesting all data 🤔

I see 3.0 have 2-4x times more metrics and chunks. Our source of metrics as of now (we are switching to avalanche soon): (config, deploy, code).

image

37 times more allocations for this PR, which suggest something is off.

image

This PR uses less memory overall, likely because of less metrics being stored.

image

This PR uses 5x more CPU

image

We kind of scrape the same amount of samples though:

image

Nothing super interesting in logs other than occasional failed scrape targets.

@bwplotka
Copy link
Member

Scrapes look healthy: http://34.89.207.251/15683/prometheus-pr/targets?pool=

@ArthurSens
Copy link
Member

37 times more allocations for this PR, which suggest something is off.

image

Comparing profiles shows problems in query/query_range APIs

image

@bwplotka
Copy link
Member

/prombench cancel

Going to cancel prombench run, so we can unblock other benchmarks runs.

@prombot
Copy link
Contributor

prombot commented Dec 20, 2024

Benchmark cancel is in progress.

@bwplotka
Copy link
Member

bwplotka commented Feb 12, 2025

As agreed in our sync I rebased and only add label in a separate PR #16025 -- I noticed potential alternative when it comes to storage model.

@github-actions github-actions bot added the stale label Apr 16, 2025
@ArthurSens
Copy link
Member

I'm closing this one since #16228 got merged, please let me know if it should remain open!

@ArthurSens ArthurSens closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants