Skip to content

Conversation

codesome
Copy link
Member

In order to do #14749, we will need an index version bump. Nothing else about how we use the index will change. I propose adding this backward compatibility to 2.55 so that there is a 2.XX version that people can downgrade to from 3.YY.

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@codesome codesome requested a review from bboreham September 18, 2024 14:30
@bboreham bboreham changed the title Backward compatibility with upcoming index v3 [Release 2.55] Backward compatibility with upcoming index v3 Sep 18, 2024
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you flipped the logic on various checks so they will treat V3 as V2.
Seems legit.

@codesome
Copy link
Member Author

It looks like you flipped the logic on various checks so they will treat V3 as V2.

Yup!

@codesome codesome enabled auto-merge September 18, 2024 14:45
@codesome codesome disabled auto-merge September 18, 2024 18:09
@codesome codesome merged commit e637ee4 into prometheus:release-2.55 Sep 18, 2024
31 checks passed
@bboreham
Copy link
Member

This needs to be done again; I force-pushed release-2.55 to remove 'mantine' UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants