fix(utf8): ensure correct validation when legacy mode turned on #14736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idation right. oops! Signed-off-by: Owen Williams <owen.williams@grafana.com>
Signed-off-by: Owen Williams <owen.williams@grafana.com>
…option Signed-off-by: Owen Williams <owen.williams@grafana.com>
|
looks like this will need an update to common |
Signed-off-by: Owen Williams <owen.williams@grafana.com>
Signed-off-by: Owen Williams <owen.williams@grafana.com>
fix unused param Signed-off-by: Owen Williams <owen.williams@grafana.com>
|
unblocked |
Signed-off-by: Owen Williams <owen.williams@grafana.com>
beorn7
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the validation scheme in common.model is set to utf8, it is still possible to set the scrapeconfig to enforce legacy validation. This PR enables that behavior. However, if the common.model scheme is set to legacy, it is not supported to check for utf-8 validity on a case-by-case basis. This restriction is currently enforced by prometheus flag checking.
fixes #14728