Skip to content

Conversation

cstyan
Copy link
Member

@cstyan cstyan commented Jul 22, 2024

Addressing comments from @bboreham on #14395 re: status of RW1.0

Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham
Copy link
Member

Should we do this on release-2.54 branch?

@cstyan
Copy link
Member Author

cstyan commented Jul 23, 2024

Should we do this on release-2.54 branch?

which is easier for you, PRing this into the release branch or into main? I can't remember if we have automation for backporting at all

@bboreham
Copy link
Member

I'm not aware of any automation; if you change the base to release-2.54 it will get merged back with everything else when the release is done.
Or you can open a second PR to cherry-pick this to that branch.

@cstyan cstyan changed the base branch from main to release-2.54 July 24, 2024 16:21
Signed-off-by: Callum Styan <callumstyan@gmail.com>
@cstyan cstyan force-pushed the rw1.0-clarify-deprecation branch from 94535a6 to a4a5994 Compare July 24, 2024 16:25
@cstyan
Copy link
Member Author

cstyan commented Jul 24, 2024

@bboreham changed base to 2.54 👍 seems like the easiest option for now

@bboreham bboreham merged commit 3ee42e1 into release-2.54 Jul 29, 2024
47 checks passed
@bboreham bboreham deleted the rw1.0-clarify-deprecation branch July 29, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants