promql: Add NHCB tests #14464
Merged
promql: Add NHCB tests #14464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zenador as promised. 😄 |
zenador
reviewed
Jul 16, 2024
| @@ -103,156 +113,314 @@ eval instant at 50m histogram_fraction(0, 0.2, rate(testhistogram3[5m])) | |||
| {start="positive"} 0.6363636363636364 | |||
| {start="negative"} 0 | |||
|
|
|||
| # Test histogram_quantile. | |||
| # In the classic histogram, we can acces the corresponding bucket (if | |||
There was a problem hiding this comment.
Suggested change
| # In the classic histogram, we can acces the corresponding bucket (if | |
| # In the classic histogram, we can access the corresponding bucket (if |
zenador
approved these changes
Jul 16, 2024
krajorama
previously approved these changes
Jul 16, 2024
| eval instant at 47m histogram_quantile(5./6., rate(testhistogram2_bucket[15m])) | ||
| {} 5 | ||
|
|
||
| # Aggregated histogram: Everything in one. | ||
| # Aggregated histogram: Everything in one. Note how NHCB doesn't require aggregation by le. |
There was a problem hiding this comment.
nit:
Suggested change
| # Aggregated histogram: Everything in one. Note how NHCB doesn't require aggregation by le. | |
| # Aggregated histogram: Everything in one. Note how native histograms don't require aggregation by le. |
This adds equivalent NHCB tests to the existing classic histogram tests. Signed-off-by: beorn7 <beorn@grafana.com>
|
Comments addressed, will merge on green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds equivalent NHCB tests to the existing classic histogram tests.