Skip to content

TestHangingNotifier is flaky on windows #16615

@machine424

Description

@machine424

First saw it on https://github.com/prometheus/prometheus/actions/runs/14931598411

then on main https://github.com/prometheus/prometheus/actions/runs/15108680391/job/42462961125

2025-05-19T09:03:35.6521434Z === RUN   TestHangingNotifier
2025-05-19T09:03:35.6521835Z     manager_test.go:848: 
2025-05-19T09:03:35.6522569Z         	Error Trace:	D:/a/prometheus/prometheus/notifier/manager_test.go:848
2025-05-19T09:03:35.6523320Z         	Error:      	"0" is not positive%!(EXTRA int=0)
2025-05-19T09:03:35.6523847Z         	Test:       	TestHangingNotifier
2025-05-19T09:03:35.6525005Z         	Messages:   	The faulty alertmanager wasn't dropped before the alerts queue was emptied.
2025-05-19T09:03:35.6525714Z --- FAIL: TestHangingNotifier (0.14s)

maybe the test depended on the locking order before #16587 and needs to be adjusted

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions