Skip to content

Quality values in Accept header in 2.48.0 are wrong #13268

@yu-shiba

Description

@yu-shiba

What did you do?

After updating Prometheus to 2.48.0, Spring Boot Actuator metrics are no longer being collected.

What did you expect to see?

It should also work correctly with 2.48.0.

What did you see instead? Under which circumstances?

Before 2.47.2, the following Accept headers were sent

application/openmetrics-text;version=1.0.0,application/openmetrics-text;version=0.0.1;q=0.75,text/plain;version=0.0.4;q=0.5,*/*;q=0.1

In 2.48.0, the following Accept header is sent, but */*;q=2 is incorrect, resulting in an error in Spring Boot.

application/openmetrics-text;version=1.0.0;q=0.5,application/openmetrics-text;version=0.0.1;q=0.4,text/plain;version=0.0.4;q=0.3,*/*;q=2

Quality Values is incorrect because it ranges from 0 through 1.
https://www.rfc-editor.org/rfc/rfc9110.html#name-quality-values

System information

Linux 5.15.133.1-microsoft-standard-WSL2 x86_64

Prometheus version

prometheus, version 2.48.0 (branch: main, revision: e4ec263bcc11493953c75d1b2e7bc78fd0463e05)
  build user:       root@aad5af94daee
  build date:       20231201-22:28:13
  go version:       go1.21.4
  platform:         linux/amd64
  tags:             netgo,builtinassets,stringlabels

Prometheus configuration file

No response

Alertmanager version

No response

Alertmanager configuration file

No response

Logs

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions