Skip to content

Conversation

johnleslie
Copy link
Contributor

procfs/nfs/parse.go's parseClientV4Stats created a ClientV4Stats struct in an order inconsistent with the kernel /proc/net/rpc/nfs output, defined in nfs4_procedures

Fixes #725

@SuperQ

@johnleslie johnleslie force-pushed the nfs-fix-clientv4stats branch from 8f51436 to a139a47 Compare May 22, 2025 00:49
…es swapped

Signed-off-by: John Leslie <johnleslie@google.com>
@johnleslie johnleslie force-pushed the nfs-fix-clientv4stats branch from a139a47 to e9d12ee Compare May 22, 2025 17:49
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 2b1359d into prometheus:master Jul 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NFSV4 client metrics: GetDeviceInfo/LayoutGet counters wrong (swapped)
2 participants