Skip to content

Do not collect InfiniBand counters for Broadcom RoCE NICs #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

Do not collect InfiniBand counters for Broadcom RoCE NICs #687

merged 1 commit into from
Apr 19, 2025

Conversation

oneoneonepig
Copy link
Contributor

Broadcom RoCE NICs (bnxt_re#) does not have the counter metrics exposed in /sys/class/infiniband/<device>/ports/<port-num>/counter.

$ strace -e trace=open,openat node_exporter --log.level=debug
...
1270794 openat(AT_FDCWD, "/sys/class/infiniband/bnxt_re0/ports/1/counters", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
...

$ ls /sys/class/infiniband/bnxt_re0/ports/1/counters
ls: cannot access '/sys/class/infiniband/bnxt_re0/ports/1/counters': No such file or directory

This will cause Node Exporter to never collect any InfiniBand metrics since it always return with error ENOENT

@oneoneonepig
Update class_infiniband.go
1e07127 
Signed-off-by: Jeffrey Chu <oneoneonepig@users.noreply.github.com>
SuperQ
SuperQ approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SuperQ SuperQ merged commit 4482eb5 into prometheus:master Apr 19, 2025
8 checks passed
@SuperQ SuperQ mentioned this pull request Apr 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oneoneonepig @SuperQ