Skip to content

Conversation

roidelapluie
Copy link
Member

No description provided.

mem and others added 2 commits June 17, 2022 14:11
The cases.Caser returned by calling cases.Title *cannot* be shared among
goroutines. This might happen when Prometheus tries to scrape multiple
targets at the same time. From the docs:

A Caser may be stateful and should therefore not be shared between
goroutines.

Fixes: prometheus#922

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roidelapluie roidelapluie changed the base branch from master to release-0.21 June 17, 2022 12:21
@roidelapluie roidelapluie merged commit e0d5e44 into prometheus:release-0.21 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants