Skip to content

Fix ios build for 1.21.1 #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix ios build for 1.21.1 #1758

merged 1 commit into from
Mar 4, 2025

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Mar 4, 2025

Fixes #1749

@bwplotka
Fix ios build.
e2b9875 
Signed-off-by: bwplotka <bwplotka@gmail.com>
@bwplotka bwplotka changed the title Fix ios build. Fix ios build for 1.21.1 Mar 4, 2025
kakkoyun
kakkoyun approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TIL client_golang is used for iOS apps.

@bwplotka bwplotka merged commit 8a42da3 into release-1.21 Mar 4, 2025
8 checks passed
@bwplotka bwplotka deleted the fix1749 branch March 4, 2025 14:06
ying-jeanne pushed a commit to ying-jeanne/client_golang that referenced this pull request Mar 28, 2025
@bwplotka @ying-jeanne
Fix ios build. (prometheus#1758)
bd45db1 
Signed-off-by: bwplotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@ArthurSens ArthurSens Awaiting requested review from ArthurSens ArthurSens is a code owner

@vesari vesari Awaiting requested review from vesari vesari is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwplotka @kakkoyun