[fix] Prevent "Cannot read property 'headers' of null" #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently there is an unidentified bug in SocketJS whereby the connection object received in the 'connection' event handler is sometimes null. This has started to happen to us when we upgraded to Node v14 (from v10) and it has happened in production a few times already causing the entire server to collapse. Please see sockjs/sockjs-node#121 and also webpack/webpack-dev-server@7964997 where webpack-dev-server implements a similar fix.
|
Is there a way to reproduce this? It would be nice to have the bug fixed upstream. |
|
cc: @brycekahle |
|
Unfortunately I don't have any additional info and I have not found any
correlation with anything else in our logs. So far it has happened just a
handful of times since we updated our Node.js version a couple of months
ago, but it has crashed our production servers every time. I know it would
be ideal to fix it upstream, but in the meantime this is all we have 🤷
…On Fri, Dec 4, 2020, 15:06 Luigi Pinca ***@***.***> wrote:
cc: @brycekahle <https://github.com/brycekahle>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#767 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZWZ7QQJQ6A74EXR265L3STD3GJANCNFSM4UI5W5OA>
.
|
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently there is an unidentified bug in SockJS whereby the connection object received in the 'connection' event handler is sometimes null. This has started to happen to us when we upgraded to Node v14 (from v10) and it has happened in production a few times already causing the entire server to collapse.
Please see sockjs/sockjs-node#121 and also webpack/webpack-dev-server@7964997 where webpack-dev-server implements a similar fix.