fix(range): improve detection of JS source elements #8419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
May 27, 2020
fisker
approved these changes
May 27, 2020
|
Didn't notice there is a range related PR, need fix snapshots. |
|
Two buttons... |
081417f to
b14fd3e
Compare
|
I updated the snapshots and added more sentence/declaration-like node types to this detection. Now I'm starting to think we should add class/interface members too. Why not? Why reformat the whole class instead of a single method? Am I missing something? |
|
I forgot how exactly range formatting works. It extracts the range and formats it as if it was a program. Class members on their own can't be parsed as a program, so disregard my previous comment. |
|
Similar to {
a: '',
^^^^^
}in JSON |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6428
Also adds detection for previously not covered types like
ForOfStatement.Prettier 2.0.5
Playground link
Input:
Output:
Prettier pr-8419
Playground link
Output:
changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨