Add more tests for reserved words #17416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
|
Thank you! |
fisker
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10603
Description
Just added missing test cases for the reserved words
yieldandlet.These words are mentioned in #10603 (comment).
These words would be contextual keywords that can be used as identifiers in certain contexts.
Adding missing test cases are required in #10603 (comment).
Note
In o-m12a@1980a53, I also unified to use
varin test snippets.This was done because, using
constorletinstead ofvarlike the following inlet.jscauses the TypeScript error
'let' is not allowed to be used as a name in 'let' or 'const' declarations. ts(2480).I'd like to avoid this compile error by using
var.Checklist
✨Try the playground for this PR✨