3.4 release blog #16851
Merged
3.4 release blog #16851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 7.86 MB ℹ️ View Unchanged
|
kachkaev
reviewed
Nov 24, 2024
There was a problem hiding this comment.
Nice! Left a couple of small suggestions.
Blog post preview:
https://deploy-preview-16851--prettier.netlify.app/blog/2024/11/25/3.4.0
| --- | ||
| author: "Sosuke Suzuki (@sosukesuzuki)" | ||
| authorURL: "https://github.com/sosukesuzuki" | ||
| title: "Prettier 3.4: Fixes a lot of bugs" |
There was a problem hiding this comment.
Suggested change
| title: "Prettier 3.4: Fixes a lot of bugs" | |
| title: "Prettier 3.4: A lot of bug fixes" |
Optional: I could not find a blog post title starting with a verb, but there was https://prettier.io/blog/2019/06/06/1.18.0 for example
website/blog/2024-11-24-3.4.0.md
Outdated
| // Input | ||
| const string = `${[[1, 2], [3, 4]]}` | ||
|
|
||
| // Prettier 3.2 |
There was a problem hiding this comment.
I believe this should be
Suggested change
| // Prettier 3.2 | |
| // Prettier 3.3 |
here and below
website/blog/2024-11-24-3.4.0.md
Outdated
| } | ||
| ``` | ||
|
|
||
| #### Fixed wrong trailing comma position after comment in SCSS ([#16617](https://github.com/prettier/prettier/pull/16617) by [@Ma-hawaj](https://github.com/Ma-hawaj), [@fisker](https://github.com/fisker)) |
There was a problem hiding this comment.
Suggested change
| #### Fixed wrong trailing comma position after comment in SCSS ([#16617](https://github.com/prettier/prettier/pull/16617) by [@Ma-hawaj](https://github.com/Ma-hawaj), [@fisker](https://github.com/fisker)) | |
| #### Fix wrong trailing comma position after comment in SCSS ([#16617](https://github.com/prettier/prettier/pull/16617) by [@Ma-hawaj](https://github.com/Ma-hawaj), [@fisker](https://github.com/fisker)) |
website/blog/2024-11-24-3.4.0.md
Outdated
|
|
||
| ### Markdown | ||
|
|
||
| #### Removed excessive spaces after line prefixes for unordered lists in Markdown ([#15526](https://github.com/prettier/prettier/pull/15526) by [@TomasLudvik](https://github.com/TomasLudvik)) |
There was a problem hiding this comment.
Suggested change
| #### Removed excessive spaces after line prefixes for unordered lists in Markdown ([#15526](https://github.com/prettier/prettier/pull/15526) by [@TomasLudvik](https://github.com/TomasLudvik)) | |
| #### Remove excessive spaces after line prefixes for unordered lists in Markdown ([#15526](https://github.com/prettier/prettier/pull/15526) by [@TomasLudvik](https://github.com/TomasLudvik)) |
|
@sosukesuzuki Please wait for me to fix #16860 |
fisker
approved these changes
Nov 25, 2024
kachkaev
approved these changes
Nov 25, 2024
kachkaev
reviewed
Nov 25, 2024
website/blog/2024-11-25-3.4.0.md
Outdated
There was a problem hiding this comment.
N.B. We’ll need to change the date if we don’t manage to release 3.4 by the end of today AoE
93705f9 to
aa4eb9f
Compare
aa4eb9f to
24ec764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#16850
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨