Markdown: preserve non-ASCII whitespaces at the end of the line and beginning of the next line #16619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ec07027 to
5c60b43
Compare
|
https://spec.commonmark.org/dingus/?text=%E3%80%80%E5%85%A8%E8%A7%92%E7%A9%BA%E7%99%BD%E3%80%80%0A Hm, the official dingus removes such spaces. |
|
It was proven to be a commonmark.js's bug. |
fisker
approved these changes
Sep 24, 2024
|
@fisker do you approve the last change of the comment (in the last commit)? |
fisker
approved these changes
Sep 24, 2024
cspell emits false-positive on `\u{feff}`
|
Line 328 in 69f4192 |
I agree with you, and I chose the way to silence cspell thanks to you. |
fisker
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The safest part of #15081
Prettier removes non-ASCII whitespaces at the end of the line and beginning of the next line in Markdown, which violates the CommonMark spec.
The space (U+3000) in the following should be kept:
# 例 全角スペース全形空白https://spec.commonmark.org/0.31.2/#soft-line-breaks
https://spec.commonmark.org/0.31.2/#unicode-whitespace-character
The CommonMark spec doesn't mention non-ASCII spaces here, so they should be reserved.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨