Skip to content

fix: tsconfig.json is not jsonc compatible #15958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: tsconfig.json is not jsonc compatible #15958

wants to merge 1 commit into from

Conversation

cbazureau
Copy link

@cbazureau cbazureau commented Jan 18, 2024 •
edited
Loading

Description

tsconfig.json is not compatible with jsonc parsing (comments are tolerated but not trailing commas). See #15956 (comment)

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@cbazureau cbazureau mentioned this pull request Jan 18, 2024
Open
@qmonmert qmonmert mentioned this pull request Jan 18, 2024
Merged
6 tasks
@fisker fisker mentioned this pull request Feb 3, 2024
Merged
3 tasks
@fisker fisker closed this in #16012 Feb 3, 2024
@fisker
Copy link
Member

fisker commented Feb 3, 2024

Thanks for working on this, changed in #16012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbazureau @fisker