Skip to content

Handlebars: Improve HTML void element check #14110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 22, 2023
Merged

Handlebars: Improve HTML void element check #14110

merged 8 commits into from
Jan 22, 2023

Conversation

fisker
Copy link
Member

@fisker fisker commented Jan 4, 2023

Description

Ref: #13691 (comment)

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker
Copy link
Member Author

fisker commented Jan 4, 2023

Turns out we can't remove this

Prettier pr-14110
Playground link

--parser glimmer

Input:

<img>
<input>

Output:

<img></img>
<input></input>

@fisker fisker changed the title Handlebars: Remove HTML void element check Handlebars: Improve HTML void element check Jan 4, 2023
sosukesuzuki
sosukesuzuki approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is good to me. But I don't know about Handlebars. @dcyriller Could you review the behaviour?

@fisker fisker merged commit 310a5b1 into prettier:main Jan 22, 2023
@fisker fisker deleted the void-element branch January 22, 2023 13:50
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 11, 2023
Merged
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
@fisker @medikoo
Handlebars: Improve HTML void element check (prettier#14110)
dca6c3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

+1 more reviewer

@dcyriller dcyriller dcyriller approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fisker @dcyriller @sosukesuzuki