Skip to content

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Nov 6, 2022

@sosukesuzuki sosukesuzuki mentioned this pull request Nov 6, 2022
11 tasks
@sosukesuzuki sosukesuzuki marked this pull request as draft November 6, 2022 10:27
Copy link
Member

@kachkaev kachkaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sosukesuzuki, looking good!

We can also backport #13590 if it’s easy, but it can wait until 3.0 too.

@sosukesuzuki
Copy link
Member Author

We can also backport #13590 if it’s easy, but it can wait until 3.0 too.

@kachkaev If you can create PR to backport it, we can maybe accept it.

@kachkaev kachkaev added this to the 2.8 milestone Nov 16, 2022
@kachkaev
Copy link
Member

kachkaev commented Nov 16, 2022

Sorry just saw your comment. Let's not bother with backporting #13590. TS 4.9 is released and I don’t want to delay 2.8 with a PR that’s not mission-critical.

@sosukesuzuki sosukesuzuki marked this pull request as ready for review November 22, 2022 09:32
---
author: "Sosuke Suzuki (@sosukesuzuki)"
authorURL: "https://github.com/sosukesuzuki"
title: "Prettier 2.8: improve --cache CLI option and TypeScript 4.9 syntax!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: "Prettier 2.8: improve --cache CLI option and TypeScript 4.9 syntax!"
title: "Prettier 2.8: improve --cache CLI option and TypeScript 4.9 satisfies operator!"
Suggested change
title: "Prettier 2.8: improve --cache CLI option and TypeScript 4.9 syntax!"
title: "Prettier 2.8: improve `--cache` CLI option and TypeScript 4.9 `satisfies` operator!"

Might be not worth the change if we plan to release 2.8.1 with Auto-Accessors in classes. On the other hand, this will align blog title with the section title and avoid overpromises.

@thorn0
Copy link
Member

thorn0 commented Nov 22, 2022

The changelog entry for #13016 was a bit difficult to follow, so I edited it. Please check if I understood it correctly.

@kachkaev kachkaev mentioned this pull request Nov 22, 2022
3 tasks
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from @kachkaev’s comment!

@sosukesuzuki sosukesuzuki merged commit ebd4542 into prettier:main Nov 23, 2022
@sosukesuzuki sosukesuzuki deleted the 2.8-blog branch November 23, 2022 05:01
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Jan 4, 2024
* Draft

* Update

* Generate

* Add `truncate`

* Address review

* Regen

* Update

* Reword changelog for prettier#13016

* Edit intro

* Edit changelog for prettier#13019

* Regenerate blog post

* Address review

Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants