Tweak gap regex for Flow #13703
Merged
Tweak gap regex for Flow #13703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn0
commented
Oct 22, 2022
| type PropTypes = {| | ||
| TestComponent: React.AbstractComponent<any>, | ||
| hello: HelloType, | ||
| |}; |
There was a problem hiding this comment.
I forgot to move this test in #13687
sosukesuzuki
approved these changes
Oct 23, 2022
fisker
reviewed
Oct 23, 2022
| // gap ^^^^ | ||
| return /^[\s(]*(\/\*(\s*::)?[\s(]*)?$/; | ||
| } | ||
| } |
There was a problem hiding this comment.
I remember there is one regexp for babel-ts? Where is it...
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, removed in #10457, forgot.
There was a problem hiding this comment.
Will /^(\s|\(|\/\*\s*::)*$/ work? This is more readable to me.
There was a problem hiding this comment.
Can we use isGap? So we can use a function, the regexp is hard to read when it's long.
function isGap(text) {
text = text.replace(/[\s\(]/g, '')
return !text || text === '/*::'
}
fisker
approved these changes
Oct 24, 2022
5 tasks
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for #13687 (comment)
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨