Preserve end-of-line comment for if statement without blocks #12017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prettier pr-12017 --parser babelInput: if (condition1) expression1; /**/ // comment A
else if (condition2) expression2; /**/ // comment B
else expression3; /**/ // comment COutput: if (condition1)
expression1; /**/
// comment A
else if (condition2)
expression2; /**/
// comment B
else expression3; /**/ // comment C |
|
@fisker I don't think such code is written in real world so we can ignore it. |
|
@fisker What do you think about this? |
fisker
reviewed
Jan 5, 2022
src/language-js/utils.js
Outdated
| /** | ||
| * This is used as a marker for dangling comments. | ||
| */ | ||
| const markerForIfWithoutBlockAndSameLineComment = |
fisker
approved these changes
Jan 5, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12011
Fixes #10250
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨