-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Closed
Labels
locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.status:needs discussionIssues needing discussion and a decision to be made before action can be takenIssues needing discussion and a decision to be made before action can be takentype:refactorIssues about tackling technical debtIssues about tackling technical debt
Description
Currently, we insert the final new line on each printer, 3rd party plugins need insert it too.
For embed print, normally this new line is not kept, 1 2 3 4.
If we move this to core.format
, should make things easier.
To make this change none breaking, we can call stripTrailingHardline
first in core.format
.
Question: Is there language can't insert the final new line? If not, plugins should not be able to prevent this behavior, if there is, how to process?
Metadata
Metadata
Assignees
Labels
locked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.status:needs discussionIssues needing discussion and a decision to be made before action can be takenIssues needing discussion and a decision to be made before action can be takentype:refactorIssues about tackling technical debtIssues about tackling technical debt