I think the logic for nvim positioning can be cribbed pretty much wholesale from https://github.com/ncm2/float-preview.nvim/blob/c5431b6d9bd4a8002f1a3eec42e9458ef4453ff3/autoload/float_preview.vim#L122

Bonus points for attaching the popup at the selected completion item rather than the top!

Bonus points for attaching the popup at the selected completion item rather than the top!

Should be easy if we can get the selected index of the popup menu, but I'm not sure if there is a way to do that.

I don't think so either; one could listen for cursor movements and keep track of the position oneself, but that seems fraught with complications.

Probably something neovim has to do using internal information, like vim does. Sounds like a reasonable feature request to expose this, though?

I think there should be a check for empty Definition -- it's showing a float even if there is no such information.

(It's also really slow for me -- but so is preview, so that's no big deal. float-preview.nvim is significantly faster, though -- do you have any idea why that could be the case? The implementation doesn't look too different.)

Maybe because of this?
https://github.com/ncm2/float-preview.nvim/blob/c5431b6d9bd4a8002f1a3eec42e9458ef4453ff3/autoload/float_preview.vim#L43-L47

Ah, so the preview is not triggering on every CompleteChanged? But it's fast even though it shows a preview for every item as I go down the list...

Probably something neovim has to do using internal information, like vim does. Sounds like a reasonable feature request to expose this, though?

What would be even better is if we have a way to customize the popup that Vim show using completeopt. Then we would automatically have the correct positioning, and there's an option to place it at the currently selected item.

That may be possible, actually. What if I set completeopt correctly, and then in my CompleteChanged handler iterate over all windows/buffers, I think I can get the one where 'preview' is set. Do you think this is worth exploring?

Ah, so the preview is not triggering on every CompleteChanged? But it's fast even though it shows a preview for every item as I go down the list...

It is, but a previous request is cancelled whenever you change the currently selected item. Do you experience the slowdown when selecting different items quickly, or also when you do it slower?

It is, but a previous request is cancelled whenever you change the currently selected item. Do you experience the slowdown when selecting different items quickly, or also when you do it slower?

Yes; it takes a second or two to update the preview float (blocking input).

That may be possible, actually. What if I set completeopt correctly, and then in my CompleteChanged handler iterate over all windows/buffers, I think I can get the one where 'preview' is set. Do you think this is worth exploring?

Hmm, maybe create the preview buffer before creating the float and then passing that to open_window? Then you'd know the buffer ID beforehand.

(Also, maybe setting style='minimal' instead of manually unsetting number` etc. helps ?)

If there's no Description, I now get the error

Error detected while processing function <lambda>431[1]..<SNR>153_show_documentation[41]..l
sp#ui#vim#output#adjust_float_placement:
line    6:
E5555: API call: 'width' key must be a positive Integer

Hmm, maybe create the preview buffer before creating the float and then passing that to open_window? Then you'd know the buffer ID beforehand.

(Also, maybe setting style='minimal' instead of manually unsetting number` etc. helps ?)

I rather meant not calling open_window and popup_create at all, but letting Vim's completeopt+=preview handle that.

Then we can use that window (already correctly positioned) and set the content ourselves.

Ideally, we should just be able to use a buffer for a completion item's 'info' field. Might be worth creating an issue at Vim for this, or do you think this would be out of scope?

(Of course, creating a buffer for each completion item is extremely unnecessary. If something like this would be implemented in Vim, we should have a way to provide this buffer on-demand. This would immediately also implement the completionItem/resolve)

I think I have it almost working now, but for two issues:

1. Preview floats contents are right-aligned (meaning the start is cut off rather than the end if the contents don't fit the screen)
2. It doesn't show for large PeekDefinition.

Maybe I should open a PR about it so we can discuss there?

Sounds good; the thing is that I'm not really familiar with nvim's API. Most of my knowledge comes from just reading output.vim. One thing that immediately catched my eye was that s:adjust_float_placement is only used for Neovim, so that's why I'm guessing that in Neovim you have to position and size the floats yourself.
Anyway, mirroring Vim's popup_create-arguments would be nice (if that's doable at least).

Not required for this but how would function overload pop up work?

@prabirshrestha
You love making things more complicated, don't you :p
I've made an issue at Vim to expand the API for info popups at vim/vim#4924, could you take a look at it and share your thoughts?
With the extra function complete_set_popup, overloads would be possible too, I suppose, provided we have a way to catch keypresses: just call complete_set_popup again if the user pressed <up> and <down>.

vim-lsp is already taken so can't create it.

I created one in discord instead. Here is the invitation link that lasts for 1 day. https://discord.gg/zpvutT

@prabirshrestha I think you can ask github to transfer the organization since the current owner is not doing anything with it -- if you want.

@clason We had asked that before, they do have private repos that are active.

Ah, OK, that's all right then. Thanks for letting me know!

Do you need an organisation for gitter? I think you can create prabirshrestha/vim-lsp as well.

@prabirshrestha Any update on gitter?

@thomasfaingnaert Yes, that should work -- the (short-lived) chatroom I mentioned was called clason/vim-lsp and connected to my fork.

I actually own this org https://github.com/vimlsp. The one without dash. So finally was able to create this. https://gitter.im/vimlsp/community.

Let me know if you want to create specific rooms. In the meantime I created https://gitter.im/vimlsp/setup for those that want to ask how to setup servers.

@thomasfaingnaert any updates on this?

@thomasfaingnaert any updated on this? Would be also good to fix merge conflicts.

@prabirshrestha I haven't had the time to work on this, unfortunately. I'll try to pick this up again in the summer.

@thomasfaingnaert do you have the branch with completionItem/resolve support that you pushed? Would be good to have a look into it too.

In the meantime doc-popup branch contains the merge conflict fixes.

@thomasfaingnaert do you have the branch with completionItem/resolve support that you pushed? Would be good to have a look into it too.

I don't think I have that branch still around, unfortunately. IIRC, there was not much to it: store the completion items in a list, and update the current completion item in that list on CompleteChanged.

@thomasfaingnaert no worries. Just wanted to know if there was support so I can review. For now will review the current one with latest fix and merge and can support completionItem/resolve later. Ideally it would had been good if neovim supported completeopt+=popup. This would had reduce lot of our logic.

Thanks for this PR.