Feat: Steam TOTP encoding #96
Conversation
| digit := value % radix | ||
| value /= radix | ||
| c := alphabet[digit] |
There was a problem hiding this comment.
nitpick: the name "Digit" has somewhat of another meaning in that library, maybe pick or pos would be clearer.
| mod := int32(value % int64(math.Pow10(l))) | ||
| switch opts.Encoder { | ||
| case otp.EncoderDefault: | ||
| mod := int32(value % int64(math.Pow10(l))) |
There was a problem hiding this comment.
One thing of note here, is that previously Digits.Lengths() could only be 6 or 8, whereas now it'll accept arbitrary values, meaning that if a user sets Digits to a negative value, that will cause a runtime panic because of the cast to int64 returning 0, since as per the spec:
When converting a floating-point number to an integer, the fraction is discarded (truncation towards zero).
This currently cannot happen because the Length function uses strconv.ParseUint which disallows sign prefixes, but it might warrant a set of comment here and there.
|
@AnomalRoil I appreciate your gratitude. If you don't mind, add patches to this PR please. |
This PR adds support for Steam TOTP encoding. totp:// URL should have
encoder=steamparam