Enable SDL_HINT_MOUSE_AUTO_CAPTURE when not using relative mode
#5163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2022
Susko3
commented
May 8, 2022
frenzibyte
reviewed
May 8, 2022
| if (window != null) | ||
| updateRelativeMode(); | ||
| }); | ||
| window.MouseAutoCapture = !e.NewValue; |
There was a problem hiding this comment.
This is actually the first time a hint is dynamically enabled/disabled. Is there a reason not to keep this enabled when relative mode is on? if so, that should be mentioned in the xmldoc of the property, for future readers.
In fact, the value of this bindable may not necessarily determine the actual internal state of RelativeMouseMode. Is there also a reason having this here and not inside the RelativeMouseMode property window-side?
There was a problem hiding this comment.
Setting in RelativeMouseMode is wrong, as relative mode is disabled when leaving the window. MouseAutoCapture should mirror UseRelativeMode.
peppy
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Partially resolves #4055. Now the issue only happens when relative mode is enabled.
To get mouse capture for relative mode, we'd probably want to do it locally in
MouseHandlerby keeping track of pressed buttons.