Skip to content

Python API using Python CFFI #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Dec 29, 2020
Merged

Python API using Python CFFI #253

merged 68 commits into from
Dec 29, 2020

Conversation

rkaminsk
Copy link
Member

@rkaminsk rkaminsk commented Dec 14, 2020 •
edited
Loading

  • set python version via definition
  • fix remaining pylint messages
  • add install target for python library
  • find a nice way to handle the path in embedded pyclingo
    • there should be a path to be able to run clingo without installing
    • otherwise, it is probably best to not set a path
  • handle visibility of declarations in embedded pyclingo
    • I did not find a way to change visibility without manually editing the files.
    • Currently, the cmake files contain a crude workaround to make it link on Windows.
    • Embedding does also not work nicely on Windows because some paths are missing.
      They can be set manually and and at least the python module works nicely.
    • This might need further fine-tuning (or maybe disable embedding on Windows).
  • improve documentation
    • Python documentation
    • C documentation
  • create pip package
    • try to reuse the code from the pip branch to do this
  • Create C++ bindings for new AST API.
    • implement bindings
    • add more tests
  • Implement unpooling (or maybe later).

rkaminsk added 29 commits December 6, 2020 21:22
@rkaminsk
initial ideas for new ast interface
b20ba33
@rkaminsk
finish value variant
6e88bb0 
This should be replaced with std::variant once clingo switches to C++17.
@rkaminsk
progress on ast traversal
3f9b17e
@rkaminsk
finish parseStatement implementation (untested)
0c6824f
@rkaminsk
refactor using variant
81c9665 
Use Michael Park's C++17 compatible variant implementation to simplify
code.
@rkaminsk
begin building ast
5061c4b
@rkaminsk
progress on ast building
e0ab82b
@rkaminsk
finish builder
e74e6d3
@rkaminsk
add basic c wrapper involving ast callbacks
395e8ba
@rkaminsk
progress on ast
a93c19f
@rkaminsk
progress on ast
ed522de
@rkaminsk
work on ast building
8e1d3f4
@rkaminsk
fine-tuning
d56193c
@rkaminsk
initial work on printing
cfc56a1
@rkaminsk
implement ast printing (untested)
42611cd
@rkaminsk
add missing files
93cc971
@rkaminsk
bugfix ast
195568d
@rkaminsk
fixes + comparison of asts
2202831
@rkaminsk
add method to add ast via program builder
ddb15bc
@rkaminsk
fixes
4684a68
@rkaminsk
rearrange and document ast
4004d19
@rkaminsk
add support for building python library using cffi
536d67a
@rkaminsk
make tests compatible with cffi API
4e841ae
@rkaminsk
add python code for cffi module
3b9f166
@rkaminsk
run pyclingo cffi unit tests
c1e5583
@rkaminsk
set pythonpath for relevant tests
26c2975
@rkaminsk
fix version output
16b4477
@rkaminsk
remove useless include
425b19d
@rkaminsk
fix pylint warnings
8822565
@rkaminsk rkaminsk changed the title Python API using python cffi Python API using Python cffi Dec 14, 2020
@rkaminsk rkaminsk marked this pull request as ready for review December 29, 2020 11:37
@rkaminsk rkaminsk added this to the v5.5.0 milestone Dec 29, 2020
@rkaminsk rkaminsk merged commit 70d4ac9 into wip Dec 29, 2020
@rkaminsk rkaminsk deleted the refactor/ast branch December 29, 2020 14:50
@rkaminsk rkaminsk linked an issue Dec 30, 2020 that may be closed by this pull request
Packaging clingo with pip #238
Closed
@becker33 becker33 mentioned this pull request Jan 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v5.5.0
Development

Successfully merging this pull request may close these issues.

Packaging clingo with pip
1 participant
@rkaminsk