Support Deno #233
Closed
Support Deno #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this is really awesome that the lib now supports deno. Thanks so much for the hard work on that lib! Ps: If you want types with deno you have to import it like that: // @deno-types="https://raw.githubusercontent.com/porsager/postgres/deno/types/index.d.ts"
import postgres from 'https://raw.githubusercontent.com/porsager/postgres/deno/deno/lib/index.js' |
|
Hi @TriForMine .. Thank you! Glad it's of use And thank you for the typescript note! Once the esm branch is merged I guess we can merge this too and add some info about "experimental deno" support in the readme. If you bump into any issues be sure to let me know. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing the esm conversion I couldn't help but try and see how far away Deno support was.
This was done by using the deno std/node modules and some polyfills for the missing parts. It's using unstable parts, so needs to run with
--unstablefor now.All tests are passing except for 3 which used
fs.createReadStreamandnet.createServer.This of course needs a lot more thought, but if you're using Deno and want to play around with it I'd love to know if it's any good.
Quick start