Fix inconsistent position calculations #1980
Merged
+110
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Nov 5, 2024
| } | ||
| return pos | ||
| } | ||
|
|
||
| positionInside(index, stringRepresentation) { | ||
| let string = stringRepresentation || this.toString() | ||
| positionInside(index) { |
There was a problem hiding this comment.
stringRepresentation argument wasn't part of the public API and it isn't needed anymore.
Comment on lines
+435
to
+436
| equal(one.positionBy({ word: 'X' }), { column: 11, line: 1 }) | ||
| equal(a.positionBy({ word: '}' }), { column: 14, line: 1 }) |
There was a problem hiding this comment.
I wanted some extra test coverage for characters at the end of nodes.
|
Sorry, I will be busy for a few days. Also, I need to review the history—maybe there was a reason to use actual CSS string and not source there. Expect merge at the end of the week. |
|
Take your time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1979
Benchmarks:
Stylelint even seems to run a bit faster after this update.
I assume that calling
String.prototype.sliceis noticeably faster than recursively callingNode.prototype.toString()and serializing all nodes.