Skip to content

Change variable name for clarity and correctness #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

Change variable name for clarity and correctness #61

merged 1 commit into from
May 28, 2019

Conversation

tim-phillips
Copy link
Collaborator

@tim-phillips tim-phillips commented May 28, 2019 •
edited
Loading

This changes runHandlerOnOptionsRequest to runHandlerOnPreflightRequest.

It's called a Preflight Request in the spec so we should call it that too.

Closes #59

@tim-phillips tim-phillips mentioned this pull request May 28, 2019
Merged
@tim-phillips tim-phillips merged commit 6bd1f34 into v1 May 28, 2019
@tim-phillips tim-phillips deleted the change-name branch May 28, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tim-phillips