Skip to content

Allow regex and array origin to determine Access-Control-Allow-Origin #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 24, 2019
Merged

Allow regex and array origin to determine Access-Control-Allow-Origin #53

merged 9 commits into from
May 24, 2019

Conversation

lucasfischer
Copy link

@lucasfischer lucasfischer commented Feb 1, 2019 •
edited by tim-phillips
Loading

after this PR micro-cors accepts origin values like https://github.com/expressjs/cors#configuration-options

Missing:

  • documentation
  • enough tests?

resolves #47

@oklas oklas mentioned this pull request Feb 23, 2019
Closed
@tim-phillips
Copy link
Collaborator

@lucasfischer thanks so much for making this PR! I'll hopefully be able to take a look at it soon.

@tim-phillips tim-phillips mentioned this pull request Feb 27, 2019
Open
9 tasks
@cryptiklemur
Copy link

Any progress on this?

tim-phillips
tim-phillips reviewed May 15, 2019
View reviewed changes
Copy link
Collaborator

@tim-phillips tim-phillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally had a bit of time to take a look. Here are some of my questions. Thanks again for putting effort into this, it's a good direction for the project.

@lucasfischer
Copy link
Author

hey @tim-phillips, thank you for helping me with this.
what will happen next? i wanna use our momentum to merge this PR asap. can i do something to accelerate this?

@tim-phillips
Copy link
Collaborator

Your welcome, thanks so much for your work. I’m going to make a couple changes and then I’ll have you review them and then I’ll merge it.

@tim-phillips
Copy link
Collaborator

tim-phillips commented May 21, 2019 •
edited
Loading

I made some changes, take a look and let me know what you think. If everything looks good then I'll merge this to the v1 branch. Refer to #58 for info about the Vary header.

@lucasfischer
Copy link
Author

looks good to me.

@lucasfischer
Copy link
Author

i made a few changes and wrote some new tests to fix the open Vary header thing:
lucasfischer@3d92a7f
should i merge it into this branch?

@tim-phillips tim-phillips changed the title add advanced options for Access-Control-Allow-Origin Allow regex and array for Access-Control-Allow-Origin May 23, 2019
@tim-phillips tim-phillips changed the title Allow regex and array for Access-Control-Allow-Origin Allow regex and array origin to determine Access-Control-Allow-Origin May 23, 2019
@tim-phillips
Copy link
Collaborator

tim-phillips commented May 23, 2019 •
edited
Loading

That commit is great, please merge and then this PR should be ready to merge to v1.

@lucasfischer
Copy link
Author

lucasfischer commented May 23, 2019 •
edited
Loading

done.

@tim-phillips tim-phillips merged commit 374fe98 into possibilities:v1 May 24, 2019
@tim-phillips tim-phillips mentioned this pull request May 28, 2019
Closed
@pudgereyem pudgereyem mentioned this pull request May 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-phillips tim-phillips tim-phillips left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfischer @tim-phillips @cryptiklemur