-
Notifications
You must be signed in to change notification settings - Fork 32
Adds successful response for OPTIONS requests without calling inner callback #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks good. Thanks for changing those I think this warrants a major version change since I know at least one person who relies on running the handler with an OPTIONS request (#28). Maybe we should include Thoughts? |
This reverts commit 5052e35.
Any reason why this was not merged yet? |
@lemol This is going to go in a “bring us up to spec” v1 release so I’m just figuring out if there will be any other breaking changes that should be included as well. |
Resolves #45