Skip to content

Adds successful response for OPTIONS requests without calling inner callback #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 24, 2018

Conversation

infernalmaster
Copy link
Contributor

@infernalmaster infernalmaster commented Nov 21, 2018

Resolves #45

@tim-phillips
Copy link
Collaborator

This looks good. Thanks for changing those deepEquals too (although they should really go in their own PR).

I think this warrants a major version change since I know at least one person who relies on running the handler with an OPTIONS request (#28). Maybe we should include preflightContinue functionality, however I'd like to name it something more obvious like runHandlerOnOptionsRequest, I'm open to suggestions.

Thoughts?

@infernalmaster infernalmaster mentioned this pull request Nov 25, 2018
@lemol
Copy link

lemol commented Dec 2, 2018

Any reason why this was not merged yet?

@tim-phillips
Copy link
Collaborator

@lemol This is going to go in a “bring us up to spec” v1 release so I’m just figuring out if there will be any other breaking changes that should be included as well.

@tim-phillips tim-phillips added the v1 label Dec 5, 2018
@tim-phillips tim-phillips mentioned this pull request Dec 5, 2018
9 tasks
@tim-phillips tim-phillips changed the base branch from master to v1 December 24, 2018 23:24
@tim-phillips tim-phillips merged commit 34c44b0 into possibilities:v1 Dec 24, 2018
@oklas oklas mentioned this pull request Feb 27, 2019
@tim-phillips
Copy link
Collaborator

tim-phillips commented May 28, 2019

Just FYI, I'm changing this config name to runHandlerOnPreflightRequest, I think it's clearer as far as the spec goes. It'll be included in v1.0.0-alpha.3.

#59
#61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants