fix(script): Receiving multiple lines rapidly only displays first line #3119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick96
requested changes
Apr 28, 2024
There was a problem hiding this comment.
Thanks a lot! Please also add a changelog entry. Otherwise, I think this is ready to merge :)
patrick96
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When a script with
tail = truereceived multiple lines quickly, the ones after the first would get buffered and never displayed.Also, if the cache started rebuilding right after the first line and the second line was received while doing so, then the second line would't get displayed.
Related Issues & Documents
Fixes #3117
Documentation (check all applicable)