Skip to content

Bug fix for strange label behavior when Cyrillic chars present in song title. #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bug fix for strange label behavior when Cyrillic chars present in song title. #3087

wants to merge 1 commit into from

Conversation

nklloyd
Copy link
Contributor

@nklloyd nklloyd commented Feb 7, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 mentioned this pull request Feb 10, 2024
Merged
9 tasks
patrick96
patrick96 approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The changes look good.

I want this to be in the next bugfix release (3.7.2). So I went ahead and ported the commit onto the release branch (see #3090) and I will merge that one

@patrick96
Copy link
Member

Merged into the 3.7.2 release branch in #3090

@patrick96 patrick96 closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick96 patrick96 patrick96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nklloyd @patrick96