Skip to content

fix: Modules did not validate tags used in formats #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: Modules did not validate tags used in formats #3045

merged 1 commit into from
Nov 16, 2023

Conversation

patrick96
Copy link
Member

@patrick96 patrick96 commented Nov 16, 2023 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

The 'value' variable that was used for validation, was empty because it was used in a move at the beginning of the function.

Related Issues & Documents

Fixes #3043

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96
fix: Modules did not validate tags used in formats
88f416b 
The 'value' variable that was used for validation, was empty because it
was used in a move at the beginning of the function.

Fixes polybar#3043
@patrick96 patrick96 marked this pull request as ready for review November 16, 2023 21:24
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (cbfbba0) 12.69% compared to head (88f416b) 12.69%.
Report is 1 commits behind head on hotfix/3.7.1.

Files Patch % Lines
src/modules/meta/base.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           hotfix/3.7.1    #3045   +/-   ##
=============================================
  Coverage         12.69%   12.69%           
=============================================
  Files               160      160           
  Lines             12531    12528    -3     
=============================================
  Hits               1591     1591           
+ Misses            10940    10937    -3
Flag Coverage Δ
unittests 12.69% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrick96 patrick96 mentioned this pull request Nov 16, 2023
Closed
5 tasks
@patrick96 patrick96 merged commit c552df3 into polybar:hotfix/3.7.1 Nov 16, 2023
@patrick96 patrick96 deleted the fix/format-tag branch November 16, 2023 21:29
@patrick96 patrick96 mentioned this pull request Nov 17, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patrick96