fix(bspwm): Restack against topmost root window. #3019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4da08f to
84cee5d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3019 +/- ##
==========================================
+ Coverage 12.69% 12.71% +0.01%
==========================================
Files 160 160
Lines 12534 12517 -17
==========================================
Hits 1591 1591
+ Misses 10943 10926 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The ewmh strategy has to be dropped because the `_NET_SUPPORTING_WM_CHECK` window may (at least in bspwm) appear anywhere in the window stack. To fix the overlapping monitors issue in polybar#2873, we simply restack against the topmost of these root windows. Fixes polybar#2972 Fixes polybar#2873 (again)
84cee5d to
e6e29a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The ewmh strategy has to be dropped because the
_NET_SUPPORTING_WM_CHECKwindow may (at least in bspwm) appear anywhere in the window stack.To fix the overlapping monitors issue in #2873, we simply restack against the topmost of these root windows.
Related Issues & Documents
Fixes #2972
Fixes #2873 (again)
Documentation (check all applicable)
The
bspwmstrategy documentation has to be revised slightly.