Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2021

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Adds a use-actual-brightness option to internal/backlight, which specifies whether to use the actual_brightness file in /sys/class/backlight/%card%/ or the brightness file. Defaults to true unless the card is an amdgpu card.

Related Issues & Documents

Fixes/closes #2367

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

https://github.com/polybar/polybar/wiki/Module:-backlight - needs the use-actual-brightness option documented.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #2380 (e704c9a) into master (50f127f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2380      +/-   ##
=========================================
- Coverage    9.92%   9.91%   -0.01%     
=========================================
  Files         147     147              
  Lines       10403   10410       +7     
=========================================
  Hits         1032    1032              
- Misses       9371    9378       +7     
Flag Coverage Δ
unittests 9.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/backlight.cpp 0.00% <0.00%> (ø)
src/modules/fs.cpp 0.00% <0.00%> (ø)
src/modules/i3.cpp 0.00% <0.00%> (ø)
src/modules/alsa.cpp 0.00% <0.00%> (ø)
include/modules/fs.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f127f...e704c9a. Read the comment docs.

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please also mention the name of the option and the name of the module in the changelog message. After that I'll merge this.

@ghost

This comment was marked as spam.

@patrick96 patrick96 merged commit 698b96d into polybar:master Feb 16, 2021
@patrick96
Copy link
Member

Thanks 👍

@ghost

This comment was marked as spam.

@patrick96
Copy link
Member

Cool 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backlight module is "delayed"
1 participant