Skip to content

feat(conf) always show urgent workspaces in i3 #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2021
Merged

feat(conf) always show urgent workspaces in i3 #2378

merged 1 commit into from
Feb 15, 2021

Conversation

zappolowski
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Given pin-workspaces = true, setting show-urgent = true will show urgent workspaces on the current bar even when the workspace is not associated with the current monitor. If pin-workspaces = false, this option has no effect.

Related Issues & Documents

Closes #2374

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes
--- wiki.old	2021-02-14 05:34:34.898430279 +0100
+++ wiki.new	2021-02-14 05:37:25.829103300 +0100
@@ -34,6 +34,16 @@
 ; Default: false
 pin-workspaces = true
 
+; Show workspaces having the urgent hint set in the bar
+; regardless of the workspace being on the current output
+; or not.
+;
+; This option only makes sense in when pin-workspaces is
+; enabled.
+;
+; Default: false
+show-urgent = true
+
 ; This will split the workspace name on ':'
 ; Default: false
 strip-wsnumbers = true

@codecov
Copy link

codecov bot commented Feb 14, 2021 •
edited
Loading

Codecov Report

Merging #2378 (67f74e4) into master (50f127f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2378      +/-   ##
=========================================
- Coverage    9.92%   9.91%   -0.01%     
=========================================
  Files         147     147              
  Lines       10403   10404       +1     
=========================================
  Hits         1032    1032              
- Misses       9371    9372       +1
Flag Coverage Δ
unittests 9.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/modules/i3.hpp 0.00% <ø> (ø)
include/utils/i3.hpp 0.00% <ø> (ø)
src/modules/i3.cpp 0.00% <0.00%> (ø)
src/utils/i3.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f127f...b5e5e15. Read the comment docs.

patrick96
patrick96 requested changes Feb 14, 2021
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Please also add an entry to the changelog: https://github.com/polybar/polybar/blob/master/CONTRIBUTING.md#changelog

@zappolowski zappolowski force-pushed the feature/i3-always-show-urgent-windows branch from 8648f41 to fec20bb Compare February 15, 2021 19:21
@zappolowski
Copy link
Contributor Author

Amended to the commit.

patrick96
patrick96 requested changes Feb 15, 2021
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small wording change. We can merge after this.

@zappolowski
feat(conf) always show urgent workspaces in i3
b5e5e15 
When `pin-workspaces` is set to true using `show-urgent` will show
urgent workspaces on the bar even when the workspace is not associated
with the current monitor.
@zappolowski zappolowski force-pushed the feature/i3-always-show-urgent-windows branch from fec20bb to b5e5e15 Compare February 15, 2021 20:21
@patrick96 patrick96 merged commit 9990032 into polybar:master Feb 15, 2021
@patrick96
Copy link
Member

Thanks! 🚀

@zappolowski zappolowski deleted the feature/i3-always-show-urgent-windows branch September 25, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick96 patrick96 patrick96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add toggle to always show urgent workspaces in i3 module
2 participants
@zappolowski @patrick96