add reverse-scroll option for xworkspaces module #2365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
=========================================
- Coverage 8.10% 8.09% -0.01%
=========================================
Files 143 143
Lines 10382 10383 +1
=========================================
Hits 841 841
- Misses 9541 9542 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks 😃
We recently decided that the next action should always go to the right and prev always to the left. Because of that the reverse-scroll option should be applied when producing the scroll actions in get_output (the same way it is done in the i3 and bspwm modules)
There was a problem hiding this comment.
Looks good now :)
I forgot to mention this before, please add your changes to the changelog: https://github.com/polybar/polybar/blob/master/CONTRIBUTING.md#changelog
What type of PR is this? (check all applicable)
Description
Added reverse-scroll option for xworkspaces module. The default is to set it to false, that way users do not have to change their configuration files if they want old behavior.
Related Issues & Documents
None
Documentation (check all applicable)
The new setting should be documented in the xworkspaces section, probably under basic settings.