Skip to content

Conversation

parmort
Copy link
Contributor

@parmort parmort commented Jan 2, 2021

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Adds an option to initially hide a module. I'm separating this from an upcoming
refactor of the visibility system to use the new action router to get this merged quicker.

; Defaults to false
hidden = true

Related Issues & Documents

Continuation of #2320

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #2342 (bf753bf) into master (412f4c7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2342      +/-   ##
=========================================
- Coverage    7.83%   7.83%   -0.01%     
=========================================
  Files         142     142              
  Lines       10298   10299       +1     
=========================================
  Hits          807     807              
- Misses       9491    9492       +1     
Flag Coverage Δ
unittests 7.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/modules/meta/base.inl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412f4c7...bf753bf. Read the comment docs.

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@patrick96 patrick96 merged commit eb302f9 into polybar:master Jan 3, 2021
@parmort parmort deleted the visibility-option branch May 9, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants