feat(xkeyboard): Add variant support to layout label #2163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2163 +/- ##
=========================================
+ Coverage 5.76% 7.89% +2.13%
=========================================
Files 139 142 +3
Lines 9987 10217 +230
=========================================
+ Hits 576 807 +231
+ Misses 9411 9410 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for contributing and thanks @kronn for reviewing :)
I did some more digging into this and there really doesn't seem to be a direct way to get the variant with xcb. There is a way using Xlib and one using values.symbolsName but neither is that straightforward and there also isn't really much documentation about the data format for these two approaches.
I think this way is works well enough.
Can you also add this to the CHANGELOG.md (https://github.com/polybar/polybar/blob/master/CONTRIBUTING.md#changelog)
|
Once (or if) this is merged, I will update the wiki with the new tag. |
|
Code looks good now. Please also add your changes to the changelog: https://github.com/polybar/polybar/blob/master/CONTRIBUTING.md#changelog You may need to rebase first because when you started this branch the changelog didn't exist yet. |
fc2af7c to
c853e58
Compare
|
I'm not sure why I still haven't benefit from this PR (I'm using polybar v 3.5.5 which was released after this PR). In my config for xkeyboard, I have: However, |
|
It's not released. I assume it will be released in 3.6; 3.5.5 is a patch release. If you want it, you'll have to build from master. The changelog is a good document to see what has and hasn't been released. |
|
Ah thanks, I assumed wrongly. |
Closes #316
Adds
%variant%variable tolabel-layoutoption in the xkeyboard module. Assuggested, I took the group name and grabbed the string inside the parens.